Thread (3 messages) 3 messages, 2 authors, 2011-01-03

Re: [PATCH V4] bridge: fix br_multicast_ipv6_rcv for paged skbs

flat view

From: David Miller <davem@davemloft.net>
Date: 2011-01-03 19:28:55

From: Tomas Winkler <redacted>
Date: Mon,  3 Jan 2011 12:37:59 +0200
use pskb_may_pull to access ipv6 header correctly for paged skbs
It was omitted in the bridge code leading to crash in blind
__skb_pull

since the skb is cloned undonditionally we also simplify the
the exit path

this fixes bug https://bugzilla.kernel.org/show_bug.cgi?id=25202
 ...
Cc: David Miller <davem@davemloft.net>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Stephen Hemminger <redacted>
Signed-off-by: Tomas Winkler <redacted>
Looks good, applied thanks Tomas.

There are several simplifications we can make in the net-next-2.6
tree.

Most of this code just wants the query type and then optionally
the ipv6 address the operation applies to.  For such simple value
fetching, skb_header_pointer() is probably ideal compared to
all of this pskb_may_pull() business.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help