Re: [PATCH net-next-2.6 1/2] can: add driver for Softing card

On Fri, Dec 24, 2010 at 12:44:08PM +0100, Marc Kleine-Budde wrote:

quoted

quoted

hmmm..all stuff behind dpram is __iomem, isn't it? I think it should
only be accessed with via the ioread/iowrite operators. Please check

I did an ioremap_nocache. Since it is unaligned, ioread/iowrite would render
a lot of statements.

The thing is, ioremapped mem should not be accessed directly. Instead
ioread/iowrite should be used. The softing driver should work on non x86
platforms, too.

I use __attribute__((packed)) structs to refer to the iomemory.
To read an unaligned uint16_t, is should then use 2 readb()'s ??

I could of course turn that sequence into a macro ....

Kurt