Re: [PATCH v2] tg3: fix return value check in tg3_read_vpd()
From: David Miller <davem@davemloft.net>
Date: 2010-12-31 20:30:47
Also in:
lkml
From: David Miller <davem@davemloft.net>
Date: 2010-12-31 20:30:47
Also in:
lkml
From: David Sterba <redacted> Date: Wed, 29 Dec 2010 14:40:31 +0100
Besides -ETIMEDOUT and -EINTR, pci_read_vpd may return other error values like -ENODEV or -EINVAL which are ignored due to the buggy check, but the data are not read from VPD anyway and this is checked subsequently with at most 3 needless loop iterations. This does not show up as a runtime bug. CC: Matt Carlson <redacted> CC: Michael Chan <mchan@broadcom.com> Signed-off-by: David Sterba <redacted>
Applied, thanks.