Thread (43 messages) 43 messages, 8 authors, 2011-01-06

Re: [PATCH V7 5/8] ptp: Added a brand new class driver for ptp clocks.

From: Arnd Bergmann <arnd@arndb.de>
Date: 2010-12-16 15:57:32
Also in: linux-api, lkml

On Thursday 16 December 2010, Richard Cochran wrote:
This patch adds an infrastructure for hardware clocks that implement
IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a
registration method to particular hardware clock drivers. Each clock is
presented as a standard POSIX clock.

The ancillary clock features are exposed in two different ways, via
the sysfs and by a character device.

Signed-off-by: Richard Cochran <redacted>
Looks fine to me, with one tiny comment:
+
+/* private globals */
+
+extern struct device_attribute ptp_dev_attrs[]; /* see ptp_sysfs.c */
The declaration is in a C file, better move it into a header in order
to make sure the definition matches the declaration.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help