Thread (5 messages) flat view 5 messages, 3 authors, 2010-10-04

Re: [PATCH 4/4] drivers/atm/idt77252.c: Remove unnecessary error check

From: David Miller <davem@davemloft.net>
Date: 2010-10-04 05:06:07
Also in: kernel-janitors, lkml

From: Julia Lawall <redacted>
Date: Sat, 2 Oct 2010 16:37:07 +0200 (CEST)
This code does not call deinit_card(card); in an error case, as done in
other error-handling code in the same function.  But actually, the called
function init_sram can only return 0, so there is no need for the error
check at all.

init_sram is also given a void return type, and its single return statement
at the end of the function is dropped.

A simplified version of the sematic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
 ...
Signed-off-by: Julia Lawall <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help