Re: [Security] TIPC security issues
From: David Miller <davem@davemloft.net>
Date: 2010-10-27 18:34:27
From: David Miller <davem@davemloft.net>
Date: 2010-10-27 18:34:27
From: Dan Rosenberg <redacted> Date: Wed, 27 Oct 2010 14:26:19 -0400
The proposed fix is a start, but it's not sufficient to completely fix the problem. What if the total of the iovecs wraps around back to 0? The total size will be returned as a small number, but large amounts of data will be copied into the allocated buffer since the individual iovecs can have arbitrary sizes.
The calculated length total is what should be used by the calling function to decide how much to copy. Sorry, I assumed the TIPC doing was sane like the rest of the networking. :-( I'll fix this up.