Re: [PATCH] atl1c: Add support for Atheros AR8152 and AR8152

On Mon, Oct 11, 2010 at 05:45:03PM -0700, Luis Rodriguez wrote:

On Mon, Oct 11, 2010 at 03:28:21PM -0700, Ben Hutchings wrote:

quoted

On Mon, 2010-10-11 at 11:48 -0700, Luis R. Rodriguez wrote:

quoted

On Sun, Oct 10, 2010 at 09:03:04PM -0700, David Miller wrote:

quoted

From: Ben Hutchings <redacted>
Date: Mon, 11 Oct 2010 02:18:50 +0100

quoted

Your commit 496c185c9495629ef1c65387cb2594578393cfe0 "atl1c: Add support
for Atheros AR8152 and AR8152" included the following changes:

 ...

quoted

quoted

+		if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b) {

 ...

quoted

quoted

+	if ((hw->nic_type == athr_l1c || hw->nic_type == athr_l2c)) {

 ...

quoted

Shouldn't the first if-statement use the same condition as the second
i.e. matching the previously-defined hardware types athr_l1c and
athr_l2c?

Yeah that definitely looks like a bug to me.

Good catch, unfortunatley I don't have the source code I used to port
this work the day I did this anymore locally, so adding 
Jie Yang who is actually our maintainer for this driver.

Jie, can you please confirm if this patch is correct?

I was suggesting that the first condition was wrong and the second was
right.

Heh, thanks, Jie can you review?

Jie, have you had any chance to review?

  Luis