Re: [PATCH v2] bonding: rejoin multicast groups on VLANs
From: Andy Gospodarek <andy@greyhouse.net>
Date: 2010-10-04 13:24:21
On Thu, Sep 30, 2010 at 05:45:24PM -0300, Flavio Leitner wrote:
It fixes bonding to rejoin multicast groups added to VLAN devices on top of bonding when a failover happens. Signed-off-by: Flavio Leitner <redacted> --- drivers/net/bonding/bond_main.c | 61 +++++++++++++++++++++++++++++++++----- drivers/net/bonding/bonding.h | 1 + 2 files changed, 54 insertions(+), 8 deletions(-)
[...]
quoted hunk ↗ jump to hunk
@@ -944,7 +979,9 @@ static void bond_mc_swap(struct bonding *bond, struct slave *new_active, netdev_for_each_mc_addr(ha, bond->dev) dev_mc_add(new_active->dev, ha->addr); - bond_resend_igmp_join_requests(bond); + + /* rejoin multicast groups */ + queue_delayed_work(bond->wq, &bond->mcast_work, 0); } }
I was hoping that one patch would just make the changes so retransmission was supported on VLANs and the second patch would queue the work and add the tunable for multiple retransmissions, but I guess it wasn't clear enough. I felt like that would divide the patches up into the bug-fix (VLANs + multicast not working) and the new feature (multiple retransmissions from the workqueue). I will test these out this morning and make sure things look good.