Hello,

On Friday 01 October 2010, Kumar SANGHVI wrote:

Hi,

On Fri, Oct 01, 2010 at 10:42:44 +0200, Rémi Denis-Courmont wrote:

quoted

quoted

I have not introduced any new ioctl()'s as part of Pipe controller
implementation.

Sure. What you did is basically worse than ioctl()'s. You've implemented
them as socket options. Socket options are meant to configure parameters
with setsockopt and read paramters with getsockopt. They are not meant
for 'doing' things - that's what ioctl()'s are for.

Isn't the existing phonet stack 'doing' something as part of
PNPIPE_ENCAP rather than simply configuring some socket option or flag ?

It sets (or gets) the delivery path for incoming data.

-- 
Rémi Denis-Courmont
http://www.remlab.net/