On Tue, 2010-09-28 at 13:10 -0400, Elly Jones wrote:

From: Elizabeth Jones <redacted>

Hi.

The readme is out of date and should be updated.

[]

+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,23)
+	usbnet = usb_get_intfdata(iface);
+#else
+	usbnet = iface->dev.platform_data;
+#endif

I think it's not particularly useful to include support
for versions < current when this driver is added.

[]

+#define DBG(format, arg...) \
+	if (debug == 1) { \
+		printk(KERN_INFO "QCUSBNet2k::%s " format, __FUNCTION__, ## arg); \
+	}

This should be surrounded by a do {} while(0)

#define DBG(fmt, arg...)							\
do {										\
	if (debug == 1)								\
		printk(KERN_INFO "QCUSBNet2k::%s " fmt, __func__, ##arg);	\
} while (0)

I think many of these DBG messages should
not use DBG but the more normal pr_<level>,
dev_<level> or netdev_<level> so generally
useful messages are logged without getting
all the debugging messages.