Re: [PATCH] xps-mq: Transmit Packet Steering for multiqueue
From: Eric Dumazet <hidden>
Date: 2010-09-01 15:54:29
Le mercredi 01 septembre 2010 à 08:41 -0700, Tom Herbert a écrit :
quoted
Why don't we do this in the normal transmit processing. There is already so much policy mechanism filters/actions/qdisc that doing it in higher level is fighting against these.Are you proposing that TX queue selection be done in the qdiscs? The queue has to be selected before taking the lock (cannot afford taking a lock over the whole interface). This would necessitate moving the locking and probably rearranging a lot of the xmit code around that.
Stephen point is not adding yet another layer 'before' qdisc layer. I would like something not as complex as your patch. 1) Why current selection fails ? 2) Could we change current selection to : - Use a lightweight selection, with no special configuration. - Use driver RX multiqueue information if available, in a one-to-one relationship. 3) Eventually have a user selectable selection (socket option, or system wide, but one sysctl, not many bitmasks ;) ).