Re: [PATCH v2] ether1: Use net_device_stats from struct net_device

From
Stephen Hemminger <hidden>
Date
2010-08-18 15:33:04
Also in
kernel-janitors, linux-arm-kernel
Reply to
Tobias Klauser, 2010-08-18
On Wed, 18 Aug 2010 09:04:24 +0200
Tobias Klauser [off-list ref] wrote:
 
-	memset (&priv(dev)->stats, 0, sizeof (struct net_device_stats));
+	memset(&dev->stats, 0, sizeof(struct net_device_stats));
This is incorrect, just remove the memset.  The stats are initialized
when device is created.  The Linux device driver convention is to
keep stats when device is set down and brought back up; that is what
the majority of other drivers do.

-- 
Thread (15 messages) 15 messages, 6 authors, last reply 2010-08-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help