Thread (34 messages) 34 messages, 7 authors, 2010-09-07

Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

From: Joe Perches <joe@perches.com>
Date: 2010-08-26 16:16:18
Also in: lkml

On Thu, 2010-08-26 at 09:05 -0700, Stephen Hemminger wrote:
+	for (i = 0; i < 6; i++)
+		printk(KERN_INFO "%2.2x%c",
+			netdev->dev_addr[i], i == 5 ? '\n' : ':');

you just want:
         printk(KERN_INFO "%pM", netdev->dev_addr);

or better yet, convert to dev_printk
or perhaps better still convert to netdev_info

My message logging order preference:

if there's a netif_msg_<type> and a struct net_device
	netif_<level>		(struct private *, netif_msg_<type>,
				 struct net_device *, fmt, args...)
if there's a struct net_device
	netdev_<level>		(struct net_device *, fmt, args...)
if there's a struct device
	dev_<level>		(struct device *, fmt, args...)
otherwise
	pr_<level>		(fmt, args...)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help