Re: [PATCH] net: define __packed for the userspace code

From
David Miller <davem@davemloft.net>
Date
2010-08-23 02:35:55
Also in
lkml
Reply to
Changli Gao, 2010-08-23
From: Changli Gao <redacted>
Date: Mon, 23 Aug 2010 10:29:49 +0800
Do you mean that use the __attribute__((packed)) annotation in all of
these files:

localhost linux # grep "\<__packed\>" usr/include/ -r | uniq
usr/include/linux/if_hippi.h:} __packed;
usr/include/linux/if_fddi.h:} __packed;
usr/include/linux/nbd.h:} __packed;
usr/include/linux/ncp.h:} __packed;
usr/include/linux/rfkill.h:} __packed;
usr/include/linux/if_pppox.h:} __packed;
usr/include/linux/phonet.h:} __packed;
usr/include/linux/ipv6.h:} __packed;    /* required for some archs */
usr/include/linux/ipv6.h:} __packed;
usr/include/linux/if_ether.h:} __packed;
It seems so, yes.

There is no way that anybody has tried to compile anything in
userspace using these headers with the __packed usage there.

If they would, they would surely see a compile failure.
Thread (8 messages) 8 messages, 3 authors, last reply 2010-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help