Thread (1 message) flat view 1 message, 1 author, 2010-08-05

Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation

From: Luis R. Rodriguez <hidden>
Date: 2010-08-05 20:48:02
Also in: kernel-janitors, linux-wireless, lkml

On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
From: Julia Lawall <redacted>

Outdent the code following the if.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
  cocci.print_main("branch",p1)
  cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <redacted>
Acked-by: Luis R. Rodriguez <redacted>
---
This patch doesn't change the semantics of the code.  But it might not be
what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.

  Luis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help