Re: [PATCH NEXT 02/10] qlcnic: add api version in reg dump
From: Ben Hutchings <hidden>
Date: 2010-08-31 15:26:48
On Tue, 2010-08-31 at 07:29 -0700, Amit Kumar Salecha wrote: [...]
quoted hunk ↗ jump to hunk
@@ -345,7 +346,10 @@ qlcnic_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p) regs->version = (1 << 24) | (adapter->ahw.revision_id << 16) | (adapter->pdev)->device; - for (i = 0; diag_registers[i] != -1; i++) + regs_buff[0] = (0xcafe0000 | (QLCNIC_DEV_INFO_SIZE & 0xffff)); + regs_buff[1] = QLCNIC_MGMT_API_VERSION; + + for (i = 2; diag_registers[i] != -1; i++) regs_buff[i] = QLCRD32(adapter, diag_registers[i]); if (!test_bit(__QLCNIC_DEV_UP, &adapter->state))
You should either bump the version number or put this extra information at the end of the register dump, not the beginning. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.