Re: [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev
From: Jarek Poplawski <hidden>
Date: 2010-08-20 19:38:42
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Plamen Petrov wrote, On 20.08.2010 12:53:
So, I guess its David and Herbert's turn?...
If you're bored in the meantime I'd suggest to do check the realtek driver eg: - for locking with the patch below, - to turn off with ethtool its tx-checksumming and/or scatter-gather, or if possible try to reproduce this with other NIC. Thanks, Jarek P. ---
diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
index f5166dc..aaaccc5 100644
--- a/drivers/net/8139too.c
+++ b/drivers/net/8139too.c@@ -1692,6 +1692,8 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb, unsigned int len = skb->len; unsigned long flags; + spin_lock_irqsave(&tp->lock, flags); + /* Calculate the next Tx descriptor entry. */ entry = tp->cur_tx % NUM_TX_DESC;
@@ -1700,14 +1702,14 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb, if (len < ETH_ZLEN) memset(tp->tx_buf[entry], 0, ETH_ZLEN); skb_copy_and_csum_dev(skb, tp->tx_buf[entry]); - dev_kfree_skb(skb); + dev_kfree_skb_irq(skb); } else { + spin_unlock_irqrestore(&tp->lock, flags); dev_kfree_skb(skb); dev->stats.tx_dropped++; return NETDEV_TX_OK; } - spin_lock_irqsave(&tp->lock, flags); /* * Writing to TxStatus triggers a DMA transfer of the data * copied to tp->tx_buf[entry] above. Use a memory barrier