Thread (3 messages) flat view 3 messages, 2 authors, 2010-08-19

Re: [PATCH] tcp: allow effective reduction of TCP's rcv-buffer via setsockopt

From: Hagen Paul Pfeifer <hidden>
Date: 2010-08-19 06:58:48

On Wed, 18 Aug 2010 23:33:37 -0700 (PDT), David Miller wrote:
From: Hagen Paul Pfeifer <redacted>
Date: Sun, 15 Aug 2010 21:36:16 +0200
quoted
+
quoted
+		if (sk->sk_userlocks & SOCK_RCVBUF_LOCK &&
quoted
+				(req->window_clamp > tcp_full_space(sk) || req->window_clamp ==
0))
quoted
+			req->window_clamp = tcp_full_space(sk);
quoted
+
Logically the patch looks fine, but please fix the indentation of the
second line of the two new if() statements in this patch, the
second line's first character should line up with the character
right after the openning "(" on the previous line.


Sorry Dave, I played with my vim settings ... I will resubmit the patch.

;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help