Re: [PATCH 1/1] ehea: Allocate stats buffer with GFP_KERNEL
From: Eric Dumazet <hidden>
Date: 2010-08-18 14:11:05
From: Eric Dumazet <hidden>
Date: 2010-08-18 14:11:05
Le jeudi 01 juillet 2010 à 22:48 -0700, David Miller a écrit :
From: Brian King <redacted> Date: Wed, 30 Jun 2010 16:59:12 -0500quoted
Since ehea_get_stats calls ehea_h_query_ehea_port, which can sleep, we can also sleep when allocating a page in this function. This fixes some memory allocation failure warnings seen under low memory conditions. Signed-off-by: Brian King <redacted>Applied to net-next-2.6 --
I believe there is a problem with this patch and/or bonding. If we say ndo_get_stats() methods are allowed to sleep, then bond_get_stats() should be updated, because it currently calls dev_get_stats() from a read_lock_bh(&bond->lock); section. Are we allowed to sleep inside a read_lock_bh() ?