Re: [PATCH] net: Fix a memmove bug in dev_gro_receive()
From: David Miller <davem@davemloft.net>
Date: 2010-08-18 00:37:38
From: David Miller <davem@davemloft.net>
Date: 2010-08-18 00:37:38
From: Jarek Poplawski <redacted> Date: Wed, 11 Aug 2010 12:02:10 +0000
quoted
Xin Xiaohui wrote: I looked into the code dev_gro_receive(), found the code here: if the frags[0] is pulled to 0, then the page will be released, and memmove() frags left. Is that right? I'm not sure if memmove do right or not, but frags[0].size is never set after memove at least. what I think a simple way is not to do anything if we found frags[0].size == 0. The patch is as followed.... This version of the patch fixes the bug directly in memmove. Reported-by: "Xin, Xiaohui" <redacted> Signed-off-by: Jarek Poplawski <redacted>
Applied thanks a lot Jarek.