Thread (24 messages) 24 messages, 7 authors, 2010-08-16

Re: [PATCH] net: add Fast Ethernet driver for PXA168.

From: Lennert Buytenhek <hidden>
Date: 2010-08-10 11:40:34

On Fri, Aug 06, 2010 at 08:44:02AM -0700, Philip Rakity wrote:
You should change
quoted
quoted
quoted
+		skb = dev_alloc_skb(MAX_PKT_SIZE + ETH_HW_IP_ALIGN);
quoted
quoted
to allocatie ADDITIONAL prepend space in the header.  If you are doing
ethernet to 802.11 routing or bridging then the wireless driver will
not have enough space in front of the header to prepend its headers
without having to allocate additional space.
This seems like something that, should you want to handle it, should be
handled centrally (e.g. by conditionally increasing NET_SKB_PAD or so)
and not hardcoded into one specific driver only.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help