Thread (3 messages) 3 messages, 2 authors, 2010-08-02

Re: [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte

From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: 2010-08-02 19:52:21
Also in: linux-serial, linux-wireless

Hey,

On Mon, Aug 02, 2010 at 08:59:26PM +0900, Komuro wrote:
quoted
--- a/drivers/net/pcmcia/xirc2ps_cs.c
+++ b/drivers/net/pcmcia/xirc2ps_cs.c
quoted
+	if (err)
	    goto config_error;
-	reg.Action = CS_WRITE;
-	reg.Offset = CISREG_IOBASE_1;
-	reg.Value = (link->io.BasePort2 >> 8) & 0xff;
-	if ((err = pcmcia_access_configuration_register(link, &reg)))
+
+	err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
+				link->io.BasePort2 & 0xff);
It should be

	err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
				(link->io.BasePort2 >> 8) & 0xff);
Fixed, thanks.

Best,
	Dominik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help