Thread (5 messages) 5 messages, 3 authors, 2010-08-02

Re: [PATCH] Multiqueue macvtap driver

From: Ben Hutchings <hidden>
Date: 2010-08-02 13:29:09

On Mon, 2010-08-02 at 18:07 +0530, Krishna Kumar2 wrote:
Thanks Ben & Dave. A question though - which of the following
is preferable for the macvtap driver:

1. Calculate flow and use that to find a queue; or
2. First check if skb_rx_queue_recorded is true and if so use
    that; otherwise calculate the flow as in #1.

I guess #1 is better, since packets for a single flow will go to the
same queue even if they arrive on different rxqs of a mq driver.
But I want to make sure.
[...]

#2 is right.  Just as macvtap should provide a stable flow to RX-queue
mapping, so should the drivers it interfaces with.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help