Re: [PATCH] net: wl12xx: do not use kfree'd memory
From: Juuso Oikarinen <hidden>
Date: 2010-08-02 05:04:11
Also in:
kernel-janitors, linux-wireless
On Sat, 2010-07-31 at 18:33 +0200, ext Kulikov Vasiliy wrote:
quoted hunk
wl1271_dump() uses cmd after kfree(cmd). Move kfree() just after wl1271_dump(). Signed-off-by: Kulikov Vasiliy <redacted> --- drivers/net/wireless/wl12xx/wl1271_spi.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c index 96d25fb..4cb99c5 100644 --- a/drivers/net/wireless/wl12xx/wl1271_spi.c +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c@@ -160,9 +160,8 @@ static void wl1271_spi_init(struct wl1271 *wl) spi_message_add_tail(&t, &m); spi_sync(wl_to_spi(wl), &m); - kfree(cmd); - wl1271_dump(DEBUG_SPI, "spi init -> ", cmd, WSPI_INIT_CMD_LEN); + kfree(cmd); } #define WL1271_BUSY_WORD_TIMEOUT 1000
Whoops ;) Good catch, thanks. Acked-by: Juuso Oikarinen <redacted> -Juuso -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html