Thread (7 messages) 7 messages, 2 authors, 2010-08-12

Re: [PATCH staging] Add SBE 2T3E3 WAN driver

From: Krzysztof Halasa <khc@pm.waw.pl>
Date: 2010-08-01 13:23:23

Greg KH [off-list ref] writes:
quoted
These entries are also needed for the tulip Ethernet driver, to avoid
initializing these ports (they are using Tulip DECchips with custom FPGA
for HDLC). I posted a patch on netdev list.
Then make the patch part of that submission, I can't add non-staging
patches to the drivers/staging/ tree if at all possible.
I did, I just didn't want a dependency and thus the change to
pci_ids.h is present in both patches, with the assumption git will take
care of it when merging.
quoted
The main reason is the interface ("PRIVATE" netdev ioctls) for
controlling the hdlcX devices is not stable. The plan is to write a new
user-kernel interface for generic HDLC, this driver (and other ones)
will then use it. For now, there is a separate utility from SBE for this
card.
Ah, ick.  Is this going to be fixed up anytime soon?
Well, I hope so. Depends on the definition of "soon", though. Something
like several months, realistically.
Care to respin this with the TODO file?`
Will do, sure.
And look, you do have a copy of the file, right there.  Care to post it
somewhere?  We need to see the license and other markings on it to know
about this driver, right?  Where did you get it from?
I got it from a friend along with a card. That's exactly what they
received from SBE. It's a driver for older Linux only, something like
up to 2.6.20 maybe. I'm told they have no newer version (i.e. working
with newer kernels; they may have a version with the new company name).

SBE (embedded devices division?) doesn't exist anymore, but this
particular piece of hardware is there:

http://www.onestopsystems.com/communication_wan_f.php

I posted the driver here:
http://userweb.kernel.org/~chris/SBE_2T3_Linux_2.0c.tgz
quoted
It seems the DRV_NAME is only used for various printk() and for
pci_request_regions(). Does it still cause problems?
It's not nice, hopefully you can fix it up.  Well, remove it entirely
would be good, but you can add that to the TODO file :)
Ah, doing a simple search & replace isn't a problem for me. Just wanted
to confirm it's not nice.

Will post a revised patch shortly, of course.
-- 
Krzysztof Halasa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help