Re: Make vhost multi-threaded and associate each thread to its guest's cgroup
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2010-07-28 01:17:34
Also in:
kvm, lkml
On Tue, Jul 27, 2010 at 05:41:41PM -0700, Sridhar Samudrala wrote:
On Tue, 2010-07-27 at 23:42 +0300, Michael S. Tsirkin wrote:quoted
Sridhar, I pushed a patchset with all known issues fixed, on my vhost-net-next branch. For now this ignores the cpu mask issue, addressing only the cgroups issue. Would appreciate testing and reports.I had to apply the following patch to get it build. With this patch, i am seeing similar results as i saw earlier. Thanks Sridhar
Excellent, thanks for the testing.
quoted hunk ↗ jump to hunk
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 996e751..8543898 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c@@ -23,6 +23,7 @@ #include <linux/highmem.h> #include <linux/slab.h> #include <linux/kthread.h> +#include <linux/cgroup.h> #include <linux/net.h> #include <linux/if_packet.h>@@ -252,7 +253,7 @@ static long vhost_dev_set_owner(struct vhost_dev *dev) } dev->worker = worker; - err = cgroup_attach_task_current_cg(poller); + err = cgroup_attach_task_current_cg(worker); if (err) goto err_cgroup; wake_up_process(worker); /* avoid contributing to loadavg */