On Wed, Jul 14, 2010 at 10:18:22AM -0700, Pankaj Thakkar wrote:

The plugin is guest agnostic and hence we did not want to rely on any
kernel provided functions. The plugin uses only the interface provided
by the shell.

Really?  vmxnet3_plugin.c is no supposed to use any kernel-provided
functions at all?  Then why have it in the kernel at all?  Seriously,
why?

The assumption is that since the plugin is really simple and straight
forward (all the control/init complexity lies in the PF driver in the
hypervisor) we should be able to get by for most of the things and for
things like memcpy/memset the plugin can write simple functions like
this.

If it's so simple, then why does it need to be separate?  Why not just
put it in your driver as-is to handle the ring-buffer logic (as that's
all it looks to be doing), and then you don't need any plugin code at
all?

It looks like you are linking this file into your "main" driver module,
so I fail to see any type of separation at all happening with this
patch.

Or am I totally missing something here?

thanks,

greg k-h