Thread (9 messages) flat view 9 messages, 4 authors, 2010-07-05

Re: Fwd: Possible bug in net/ipv4/route.c?

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2010-07-05 12:06:25
Also in: lkml

Eric Dumazet [off-list ref] wrote:
quoted
2) The layer using skb->cb[] should clear this area after use and
before handing the skb to another layer.  Ubicom should modify the
driver to clear the skb->cb[] area before sending it up the line.
This is the right option. If you use one word in cb[], only your driver
knows how to clear it efficiently.
Absolutely not! No protocol stack should rely on an external skb
having a zero cb.

Please fix the bridge instead as it's doing the IP injection.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help