On 7/1/2010 7:55 AM, Peter Zijlstra wrote:

On Thu, 2010-07-01 at 16:53 +0200, Tejun Heo wrote:
   

quoted

Hello,

On 07/01/2010 04:46 PM, Oleg Nesterov wrote:
     

quoted

quoted

It might be a good idea to make the function take extra clone flags
but anyways once created cloned task can be treated the same way as
other kthreads, so nothing else needs to be changed.
         

This makes kthread_stop() work. Otherwise the new thread is just
the CLONE_VM child of the caller, and the caller is the user-mode
task doing ioctl() ?
       

Hmmm, indeed.  It makes the attribute inheritance work but circumvents
the whole reason there is kthreadd.
     

I thought the whole reason there was threadd was to avoid the
inheritance? So avoiding the avoiding of inheritance seems like the goal
here, no?
   

I think so. Does  it (Tejun's kthread_clone() patch) also  inherit the 
cgroup of the caller? or do we still need the explicit
call to attach the thread to the current task's cgroup?

I am on vacation next week and cannot look into this until Jul 12. Hope 
this will be resoved by then.
If not, i will look into after i am back.

Thanks
Sridhar