Thread (4 messages) 4 messages, 2 authors, 2010-07-02

Re: [PATCH ethtool 2/2] ethtool: Add support for control of RX flow hash indirection

From: Ben Hutchings <hidden>
Date: 2010-07-01 16:03:48

On Wed, 2010-06-30 at 16:13 +0100, Ben Hutchings wrote:
Many NICs use an indirection table to map an RX flow hash value to one
of an arbitrary number of queues (not necessarily a power of 2).  It
can be useful to remove some queues from this indirection table so
that they are only used for flows that are specifically filtered
there.  It may also be useful to weight the mapping to account for
user processes with the same CPU-affinity as the RX interrupts.
[...]
+	printf("RX flow hash indirection table for %s with %llu RX ring(s):\n",
+	       devname, ring_count.data);
+	for (i = 0; i < indir->size; i++) {
+		if (i % 8 == 0)
+			printf("%5zu: ", i);
+		printf(" %5u", indir->ring_index[i]);
+		if (i % 8 == 7)
+			fputc('\n', stdout);
+	}
[...]

The "%5zu: " above should be "%5u: ".  I can either send another patch
or leave you to fix this up, as you prefer.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help