Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
From: Miles Lane <hidden>
Date: 2010-06-09 16:28:19
Also in:
lkml
From: Miles Lane <hidden>
Date: 2010-06-09 16:28:19
Also in:
lkml
On Wed, Jun 9, 2010 at 11:24 AM, Peter Zijlstra [off-list ref] wrote:
On Wed, 2010-06-09 at 11:11 -0400, Miles Lane wrote:quoted
Sorry. I misunderstood this message when I first read it. I didn't realize this message include a new version of the patch. Anyhow, I just tried to apply the patch to 2.6.35-rc2-git3 and got this: # patch -p1 -l -F 20 --dry-run < ../5.patch patching file include/linux/cgroup.h patching file kernel/sched.c Hunk #1 succeeded at 306 with fuzz 1. Hunk #3 FAILED at 4462. Hunk #4 succeeded at 4487 with fuzz 3. 1 out of 4 hunks FAILED -- saving rejects to file kernel/sched.c.rejWeird.. it seems to apply without trouble to Linus' git tree. root@twins:/usr/src/linux-2.6# git checkout -f origin/master HEAD is now at 84f7586... Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 root@twins:/usr/src/linux-2.6# quilt push Applying patch patches/sched-rcu-validation.patch patching file include/linux/cgroup.h patching file kernel/sched.c Now at patch patches/sched-rcu-validation.patch root@twins:/usr/src/linux-2.6# git describe v2.6.35-rc2-54-g84f7586
Oh. Duh. I know what is going on. I had received another patch to sched.c. They must conflict. I will test with just your patch now.