Thread (19 messages) 19 messages, 7 authors, 2010-07-06

Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags

From: David Miller <davem@davemloft.net>
Date: 2010-06-30 21:10:14

From: Ben Hutchings <redacted>
Date: Wed, 30 Jun 2010 13:44:32 +0100
ethtool_op_set_flags() does not check for unsupported flags, and has
no way of doing so.  This means it is not suitable for use as a
default implementation of ethtool_ops::set_flags.

Add a 'supported' parameter specifying the flags that the driver and
hardware support, validate the requested flags against this, and
change all current callers to pass this parameter.

Change some other trivial implementations of ethtool_ops::set_flags to
call ethtool_op_set_flags().

Signed-off-by: Ben Hutchings <redacted>
Reviewed-by: Stanislaw Gruszka <redacted>
Acked-by: Jeff Garzik <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help