Re: [net-next-2.6 PATCH] be2net: memory barrier fixes on IBM p7 platform
From: David Miller <davem@davemloft.net>
Date: 2010-06-30 20:27:35
From: Sathya Perla <redacted> Date: Tue, 29 Jun 2010 15:41:17 +0530
The ibm p7 architecure seems to reorder memory accesses more aggressively than previous ppc64 architectures. This requires memory barriers to ensure that rx/tx doorbells are pressed only after memory to be DMAed is written. Signed-off-by: Sathya Perla <redacted>
Applied, but I had to fix something:
quoted hunk ↗ jump to hunk
@@ -972,7 +976,8 @@ static struct be_eth_rx_compl *be_rx_compl_get(struct be_adapter *adapter) if (rxcp->dw[offsetof(struct amap_eth_rx_compl, valid) / 32] == 0) return NULL; - + + rmb();
That first addition does nothing but add erroneous trailing whitespace. You can physically see that something must be wrong here just by look at this patch chunk, please review things more thoroughly before submitting in the future. Thanks.