Wed, Jun 30, 2010 at 02:53:17PM CEST, kaber@trash.net wrote:

Jiri Pirko wrote:

quoted

Wed, Jun 30, 2010 at 02:10:31PM CEST, kaber@trash.net wrote:

quoted

Jiri Pirko wrote:

quoted

This patch removes deprecated config option NF_CT_ACCT. The default value is set
to 0 and warning message is put into connbytes_mt_init (connbytes selected
NF_CT_ACCT to enable it by default).

Thanks, I already have a patch queued in nf-next for this.

Oh, I see that: d70a011dbbaa6335a19deb63ec3eb613f48faafd

a8756201ba4189bca3ee1a6ec4e290f467ee09ab also belongs to the removal.

quoted

Apart your patch doesn't remove option from defconfigs (not sure if that's
necessary or not), your patch also do not print warning in connbytes_mt_init.
That would make connbytes silently non-functional. Therefore I think my patch is
better (more complete).

The patch I have queued is automatically enabling accounting when
the connbytes match is used and is printing a warning.

ok, that looks fine to me. What about those config options in def_config files?