Re: [PATCH] net/core: use htons for skb->protocol
From: David Daney <hidden>
Date: 2010-06-29 22:19:12
On 06/29/2010 09:32 AM, Sebastian Andrzej Siewior wrote:
quoted hunk ↗ jump to hunk
From: Sebastian Andrzej Siewior<bigeasy@linutronix.de> This is only noticed by people that are not doing everything correct in the first place. Signed-off-by: Sebastian Andrzej Siewior<bigeasy@linutronix.de> --- net/core/dev.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)diff --git a/net/core/dev.c b/net/core/dev.c index 2b3bf53..78ad37c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c@@ -1541,7 +1541,8 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev) if (net_ratelimit()) printk(KERN_CRIT "protocol %04x is " "buggy, dev %s\n", - skb2->protocol, dev->name); + htons(skb2->protocol),
Would ntohs() be more appropriate here? It looks like you are converting from network order to host order for printing. David Daney