Re: [PATCH] cpmac: do not leak struct net_device on phy_connect errors
From: Florian Fainelli <florian@openwrt.org>
Date: 2010-06-27 17:05:17
Hi David, Forgot to mention that this is relevant for -stable and current net-next-2.6. Thanks! Le Monday 21 June 2010 10:07:48, Fainelli a écrit :
quoted hunk ↗ jump to hunk
If the call to phy_connect fails, we will return directly instead of freeing the previously allocated struct net_device. Signed-off-by: Florian Fainelli <florian@openwrt.org> CC: stable@kernel.org ---diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c index 3c58db5..23786ee 100644 --- a/drivers/net/cpmac.c +++ b/drivers/net/cpmac.c@@ -1181,7 +1181,8 @@ static int __devinit cpmac_probe(structplatform_device *pdev) if (netif_msg_drv(priv)) printk(KERN_ERR "%s: Could not attach to PHY\n", dev->name); - return PTR_ERR(priv->phy); + rc = PTR_ERR(priv->phy); + goto fail; } if ((rc = register_netdev(dev))) {