Re: [PATCH] net/core: Save the port number a netdevice uses

From: Ben Hutchings <bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
Date: Wed, 02 Jun 2010 17:42:29 +0100

On Wed, 2010-05-26 at 02:16 -0700, David Miller wrote:

quoted

From: Eli Cohen <redacted>
Date: Wed, 26 May 2010 12:08:52 +0300

quoted

So if I understand you correctly, you think that I should not bother
to set a default value of 1. Each driver that cares about the value
of this field, will set it however they want.

I actually mean that the value "0" should mean the first port,
the value "1" should mean the second port, etc.

There's a compatibility problem here though: when user-space looks at
this number it can't tell whether "0" really means the first port or
that the driver isn't setting dev_id.

That's perfect, it means we don't have to add explicit settings to
drivers which driver only one port.  Ie. the vast majority of
cases.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html