Re: [PATCH 1/3] korina: fix deadlock on RX FIFO overrun
From: David Miller <davem@davemloft.net>
Date: 2010-06-02 13:12:24
From: David Miller <davem@davemloft.net>
Date: 2010-06-02 13:12:24
From: Phil Sutter <phil@nwl.cc> Date: Sun, 30 May 2010 01:23:34 +0200
By calling korina_restart(), the IRQ handler tries to disable the interrupt it's currently serving. This leads to a deadlock since disable_irq() waits for any running IRQ handlers to finish before returning. This patch addresses the issue by turning korina_restart() into a workqueue task, which is then scheduled when needed. Reproducing the deadlock is easily done using e.g. GNU netcat to send large amounts of UDP data to the host running this driver. Note that the same problem (and fix) applies to TX FIFO underruns, but apparently these are less easy to trigger. Signed-off-by: Phil Sutter <phil@nwl.cc>
Applied.