Re: [PATCH] ixp4xx: Support the all multicast flag on the NPE devices.
From: Richard Cochran <richardcochran@gmail.com>
Date: 2010-05-31 15:34:19
Also in:
linux-arm-kernel
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2010-06-01 · [PATCH] ixp4xx: Support the all multicast flag on the NPE devices. · davem@davemloft.net (David Miller)
- 2010-05-31 · [PATCH] ixp4xx: Support the all multicast flag on the NPE devices. · khc@pm.waw.pl (Krzysztof Halasa)
- 2010-05-31 · [PATCH] ixp4xx: Support the all multicast flag on the NPE devices. · khc@pm.waw.pl (Krzysztof Halasa)
- 2010-05-31 · [PATCH] ixp4xx: Support the all multicast flag on the NPE devices. · richardcochran@gmail.com (Richard Cochran)
On Mon, May 31, 2010 at 04:09:13PM +0200, Krzysztof Halasa wrote:
Looks good, though I'd prefer a bit of "const" and "static" in the allmulti[] declaration. Would you please repost? TIA.
Okay, here it is. Thanks, Richard This patch adds support for the IFF_ALLMULTI flag. Previously only the IFF_PROMISC flag was supported. Signed-off-by: Richard Cochran <redacted> --- drivers/net/arm/ixp4xx_eth.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/net/arm/ixp4xx_eth.c b/drivers/net/arm/ixp4xx_eth.c
index 6be8b09..42b4361 100644
--- a/drivers/net/arm/ixp4xx_eth.c
+++ b/drivers/net/arm/ixp4xx_eth.c@@ -739,6 +739,17 @@ static void eth_set_mcast_list(struct net_device *dev) struct dev_mc_list *mclist; u8 diffs[ETH_ALEN], *addr; int i; + static const u8 allmulti[] = { 0x01, 0x00, 0x00, 0x00, 0x00, 0x00 }; + + if (dev->flags & IFF_ALLMULTI) { + for (i = 0; i < ETH_ALEN; i++) { + __raw_writel(allmulti[i], &port->regs->mcast_addr[i]); + __raw_writel(allmulti[i], &port->regs->mcast_mask[i]); + } + __raw_writel(DEFAULT_RX_CNTRL0 | RX_CNTRL0_ADDR_FLTR_EN, + &port->regs->rx_control[0]); + return; + } if ((dev->flags & IFF_PROMISC) || netdev_mc_empty(dev)) { __raw_writel(DEFAULT_RX_CNTRL0 & ~RX_CNTRL0_ADDR_FLTR_EN,
--
1.6.3.3