Re: [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices
From: Flavio Leitner <hidden>
Date: 2010-05-31 19:08:29
Also in:
bridge, lkml
On Mon, May 31, 2010 at 01:56:52PM +0800, Cong Wang wrote:
Hi, Flavio, Please use the attached patch instead, try to see if it solves all your problems.
I tried and it hangs. No backtraces this time. The bond_change_active_slave() prints before NETDEV_BONDING_FAILOVER notification, so I think it won't work. Please, correct if I'm wrong, but when a failover happens with your patch applied, the netconsole would be disabled forever even with another healthy slave, right? fbl
Thanks a lot!
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index ca142c4..2d1d594 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c@@ -666,7 +666,8 @@ static int netconsole_netdev_event(struct notifier_block *this, struct net_device *dev = ptr; if (!(event == NETDEV_CHANGENAME || event == NETDEV_UNREGISTER || - event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN)) + event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN || + event == NETDEV_BONDING_FAILOVER)) goto done; spin_lock_irqsave(&target_list_lock, flags);@@ -682,6 +683,7 @@ static int netconsole_netdev_event(struct notifier_block *this, /* Fall through */ case NETDEV_GOING_DOWN: case NETDEV_BONDING_DESLAVE: + case NETDEV_BONDING_FAILOVER: nt->enabled = 0; break; }
-- Flavio