Re: [PATCH] netfilter: don't xt_jumpstack_alloc twice in xt_register_table
From: Patrick McHardy <hidden>
Date: 2010-05-31 14:34:37
Also in:
lkml, netfilter-devel
From: Patrick McHardy <hidden>
Date: 2010-05-31 14:34:37
Also in:
lkml, netfilter-devel
Jan Engelhardt wrote:
On Monday 2010-05-31 13:51, Jan Engelhardt wrote:quoted
On Monday 2010-05-31 13:06, Xiaotian Feng wrote:quoted
In xt_register_table, xt_jumpstack_alloc is called first, later xt_replace_table is used. But in xt_replace_table, xt_jumpstack_alloc will be used again. Then the memory allocated by previous xt_jumpstack_alloc will be leaked. We can simply remove the previous xt_jumpstack_alloc because there aren't any users of newinfo between xt_jumpstack_alloc and xt_replace_table.Indeed that seems to be so.Acked-By: Jan Engelhardt <redacted>
Applied, thanks everyone.