Thread (9 messages) 9 messages, 4 authors, 2010-05-28

Re: boot crash in arp_error_report()

From: Ingo Molnar <hidden>
Date: 2010-05-28 08:24:52
Also in: lkml

* Ingo Molnar [off-list ref] wrote:
* David Miller [off-list ref] wrote:
quoted
From: Eric Dumazet <redacted>
Date: Thu, 27 May 2010 22:18:24 +0200
quoted
[PATCH] net: fix __neigh_event_send()

commit 7fee226ad23 (net: add a noref bit on skb dst) missed one spot
where an skb is enqueued, with a possibly not refcounted dst entry.

__neigh_event_send() inserts skb into arp_queue, so we must make sure
dst entry is refcounted, or dst entry can be freed by garbage collector
after caller exits from rcu protected section.

Reported-by: Ingo Molnar <redacted>
Signed-off-by: Eric Dumazet <redacted>
Applied, thanks Eric.

Ingo can we get a confirmation that this fixes the bootup crash?
Sure, will let you know how it goes.
Preliminary testing shows that Eric's patch solves the problem.

Tested-by: Ingo Molnar <redacted>

Thanks!

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help