Thread (19 messages) 19 messages, 3 authors, 2010-06-01

Re: [PATCH] net: fix lock_sock_bh/unlock_sock_bh

From: Anton Blanchard <hidden>
Date: 2010-05-27 06:09:50

quoted
[PATCH v2] net: fix lock_sock_bh/unlock_sock_bh

This new sock lock primitive was introduced to speedup some user context
socket manipulation. But it is unsafe to protect two threads, one using
regular lock_sock/release_sock, one using lock_sock_bh/unlock_sock_bh

This patch changes lock_sock_bh to be careful against 'owned' state.
If owned is found to be set, we must take the slow path.
lock_sock_bh() now returns a boolean to say if the slow path was taken,
and this boolean is used at unlock_sock_bh time to call the appropriate
unlock function.

After this change, BH are either disabled or enabled during the
lock_sock_bh/unlock_sock_bh protected section. This might be misleading,
so we rename these functions to lock_sock_fast()/unlock_sock_fast().

Reported-by: Anton Blanchard <redacted>
Signed-off-by: Eric Dumazet <redacted>
Looks good, I'll wait for positive testing from Anton before applying
this.
Thanks guys, this fixed it.

Tested-by: Anton Blanchard <redacted>

Anton
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help