Paweł Staszewski wrote:

W dniu 2010-03-31 11:46, Patrick McHardy pisze:

quoted

quoted

quoted

quoted

tc filter add dev eth0 protocol ip parent 1:101 u32 match ip
protocol 1
0xff flowid 1:101

ping 212.77.100.101
And after this server will stop responding to anything - without any
error (hang).

         

This is caused by hfsc_classify() looping endlessly since the filter
points to the originating class. hfsc_bind_tcf() is actually supposed
to prevent this, but it only prevents resolving the filter immediately
and we still run into the loop at runtime.

This patch (based on how CBQ handles this) should abort classification
and fall back to the default class. It would be better to simply catch
this at configuration time, but that looks a bit more involved. I'll
try
to look into it this weekend.



       

I check this also with htb and the same problem like with hfsc.
This rules also hang my server.
     

Yes, HTB doesn't even catch loops when binding filters. As I said,
its a larger piece of work, for now please just try the patch I
sent.
   

Yes.
Your patch fix this problem.

Thanks for testing, I'll let you know once I have a complete
patch for this problem.