Thread (32 messages) 32 messages, 6 authors, 2010-04-02

Re: [PATCH v3 04/12] l2tp: Add ppp device name to L2TP ppp session data

From: James Chapman <jchapman@katalix.com>
Date: 2010-03-31 07:43:18

Stephen Hemminger wrote:
On Tue, 30 Mar 2010 17:17:46 +0100
James Chapman [off-list ref] wrote:
quoted
When dumping L2TP PPP sessions using /proc/net/l2tp, get
the assigned PPP device name from PPP using ppp_dev_name().

Signed-off-by: James Chapman <jchapman@katalix.com>
Reviewed-by: Randy Dunlap <redacted>
Why is this a necessary API?
Why not put it in debugfs if just a debugging tool?
With the original driver (merged in 2.6.23), some people use horrible
hacks in scripts to derive info about their L2TP connections from /proc.
So I was reluctant to move it to debugfs in the new driver. If it is ok
to move an existing /proc file to debugfs, I'm happy to do so. People
should obtain such info from their L2TP userspace daemon, or through
netlink anyway.


-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help