Thread (2 messages) 2 messages, 2 authors, 2010-03-30

Re: Tiny patch (w/ discussion) to provide the peer information on unix domain sockets

flat view

From: Erkki Seppala <hidden>
Date: 2010-03-30 17:46:38

Hi Eric,

On Tue, Mar 30, 2010 at 04:56:53PM +0200, Eric Dumazet wrote:
Such patches should be sent to netdev
Oops! Thanks for the pointer!
I believe you missed some necessary locking.
I don't think so, because I don't actually dereference the other unix
address, I just print the its address.
Prior art from Kenan Kalajdzic :

 http://patchwork.ozlabs.org/patch/46561/
Perhaps this would be a more decent solution (using the more
user-space compatible concept of inodes), although I think don't that
the backwards compatiblity for this kind of rarely used feature is
that critical, given the impact of the breakage seems to be quite low
as well.

I think the way forward in general should be that user space
applications actually look what columns are available and provide
future compatibility in that fashion. And empty fields should have
have some filler :).

-- 
  _____________________________________________________________________
     / __// /__ ____  __               http://www.modeemi.fi/~flux/\   \
    / /_ / // // /\ \/ /                                            \  /
   /_/  /_/ \___/ /_/\_\@modeemi.fi                                  \/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help