Thread (35 messages) 35 messages, 3 authors, 2010-03-31

Re: [PATCH 4/7] flow: delayed deletion of flow cache entries

From: Timo Teräs <hidden>
Date: 2010-03-30 12:43:57

Herbert Xu wrote:
On Tue, Mar 30, 2010 at 03:32:58PM +0300, Timo Teräs wrote:
quoted
If flow cache regeneration or shrinking is triggered in lookup,
it would previously free it in place. Now that is deferred. But
yes, it's more useful after the next patches that call the
virtual destructor. Should have explained this better.
Any chance you can refactor them so that this comes after the
virtual get/put patch?

That way can evaluate this on its own merit rather than being
a prerequisite for the more important stuff.
I thought it's not good to have possible speed regressions even
temporarily in the tree, so I figured this should go first.

But sure, I'll refactor this to be a later commit for the next
iteration.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help