Thread (9 messages) flat view 9 messages, 2 authors, 2010-03-15

Re: [PATCH 3/6] smsc95xx: add constant definition for SMSC USB vendor id

From: David Miller <davem@davemloft.net>
Date: 2010-03-15 22:38:39

From: Steve Glendinning <redacted>
Date: Wed, 10 Mar 2010 18:32:36 +0000
Signed-off-by: Steve Glendinning <redacted>
I don't see any real need for this, really.  It's a constant,
device ID tables are constants and people know how to go lookup
a vendor ID if they really want to know who it is.  This doesn't
add any readability to the driver at all.

Also you're mixing cleanups and bug fixes into your patch
set.  Please seperate out the pure bug fixes so I can apply
them to net-2.6  The rest can go in later when net-next-2.6
opens up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help