Thread (2 messages) 2 messages, 2 authors, 2010-02-28

Re: [PATCH] ethtool: do not set some flags, if others failed

From: David Miller <davem@davemloft.net>
Date: 2010-02-28 09:40:28

From: Jeff Garzik <redacted>
Date: Sat, 27 Feb 2010 02:43:38 -0500
NETIF_F_NTUPLE flag setting introduced a bug:  non-ntuple flags
like LRO may be successfully set, before ioctl(2) returns failure
to userspace.

The set-flags operation should be all-or-none, rather than leaving
things in an inconsistent state prior to reporting failure to
userspace.

Signed-off-by: Jeff Garzik <redacted>
Applied, thanks Jeff.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help