Thread (10 messages) 10 messages, 4 authors, 2010-03-08

Re: [net-next-2.6 PATCH v2] net: consolidate netif_needs_gso() checks

From: David Miller <davem@davemloft.net>
Date: 2010-02-28 08:29:24

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 28 Feb 2010 08:29:53 +0800
On Sat, Feb 27, 2010 at 08:17:09AM -0800, David Miller wrote:
quoted
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 27 Feb 2010 23:52:45 +0800
quoted
I just did a grep on net/sched and couldn't see anything obvious
that uses transport_header.
I think skb_checksum_help() would be such a use and I
see a reference in net/sched/sch_netem.c
AFAICS skb_checksum_help uses csum_start and not transport_header.
Has this changed recently?

Once upon a time some drivers used transport_header instead of
csum_start, but even those seem to be gone mostly so one day we
could remove this setting completely.
Ok, then this clears up all of my concerns.  Thanks Herbert.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help